Anyway, this was a lot more complicated than I originally figured. There’s a lot of math to slice and dice the current price to make sure that the lines are actually straddled around your current position.

The indicator has several configurable options, including number of lines to draw, the pip gap between the lines, the line size, style and color, as well as if you’d like the lines to continuously update as price goes up and down. This continuous option seems a bit silly to me, as it does a lot of work each tick for really no reason, but some folks may want it to work that way. By default, this is set to false.

Here’s a snapshot:

Get this indicator:

nPipLines.mq4
nPipLines.zip

The reference that I found had the code for an indicator from MT3, so I recoded it for MT4.  I don’t know how useful it is yet, but I thought I would post and update it if necessary.

Here’s a snapshot:

Get this indicator:

EldersSafeZone.mq4
EldersSafeZone.zip

Some indicators out there would provide such a thing, but didn’t go as far as I would have liked.  So, I put hacked up someone else’s MA of Volume indicator and added a JMA option, as well as a dynamically changing level that is based upon a configurable number of days average.

Ever want to quickly see if the MA of volume is high or low based on the last 120 days?  30 days?  Now you can!

Here’s a snapshot:

Get this indicator:

MAVolumeWithJMA.mq4
MAVolumeWithJMA.zip

In that post, I made the offer to whip up a version that had its own indicator window, if anyone thought it would be useful. Someone (Barry) did, so now we have three flavors of 3 Fold Trading Hours.

Original: Visual reminder via a chart comment
New: Visual reminder via a new indicator window (available below)
Also: Time filter for an Expert Adviser to actually stop trading from happening

This new indicator also displays a bit more information as well, like listing out the filter times, and if they are used or not. The time filter logic is taken from the EA version, so that you can now filter by hours and minutes, not just hours, as with the original.

Here’s a snapshot:

Get this indicator:

3FoldTradingHoursSeparateWindow.mq4
3FoldTradingHoursSeparateWindow.zip

In the process of changing the logic for use in an EA, I also improved on the previous indicator. You can now use hours and minutes, not just hours for the configured time frames.

The file below is not a new indicator, but is intended to be included in an EA. Its is the 3 Fold Trading Hours logic turned into a boolean function. Simply wrap all your EA logic in the call to HourlyFilter(); It returns true when the time is within your specified hours, and false when it’s not.

Pseudo code for placement in the Start() function is:

if HourlyFilter()
{
PerformEALogic();
}
else return (0);

UPDATE: There was an error in the source, which has now been fixed.  Filter 3 was being checked twice, and Filter 2 was being ignored.  Sorry for any inconvenience.

3FoldTradingFilterforEA.mq4
3FoldTradingFilterforEA.zip

So, I made a function to do so. In this case, we really want the function to give us two things:

1. If the value exists in the array’s second dimension
2. If it does exist, the actual coordinates of where

Ideally, you could do this with as little “usage hassle” as possible. So, the function that I’ve written does the following:

1. It uses a 2 bucket single-dimension array to hold the coordinates of our search value. This array should be declared prior to calling the search function. The search function updates the value of the array because the array is “passed by reference”.
2. The function itself of a boolean type, so a return of “true” means it was found, and “false” means it wasn’t.

Here is the function spec:

SearchSecondDim (ReturnArray, ArrayToSearch, ValueToSearch, SearchDirection)

Return Values:

True or False
With ReturnArray passed by reference so that after function is run:
ReturnArray [0] = ArrayToSearch first dimension location
ReturnArray [1] = ArrayToSearch second dimension location
if ReturnArray [0] or ReturnArray [1] = -1 value was not found.

NOTE: ReturnArray[2] need to be declared prior to using this function!

Example 1:

double MySearchArray[10][5];
ArrayInitialize(MySearchArray,0);
MySearchArray [7][5] = 7;
double foo[2];
bool FoundIt = SearchSeconDim (foo,MySearchArray,7,MODE_ASCEND);

This will set foo[0]==7 and foo[1]==5. Also, FoundIt will be “true”.

Example 2:

double MySearchArray[10][5];
ArrayInitialize(MySearchArray,0);
MySearchArray [7][5] = 7;
double foo[2];
bool FoundIt = SearchSeconDim (foo,MySearchArray,10,MODE_ASCEND);

This will set foo[0]==-1 and foo[1]==-1 since the value isn’t anywhere in the array’s second dimension. Also, FoundIt will be “false”.

Some Extra Goodies!

Also included in this file, is the single dimension array search function that I posted earlier (see that post for more details) and 2 simple array “printing” functions. These printing functions output to the “Experts” tab of MT4’s terminal window.

Printing a 1 dimensional array:

PrintSingleArray(double ArrayToPrint[])

Return Values:

None / Void.
A single comma separated line is printed to the Experts output window.

Printing a 2 dimensional array:

PrintDblArray(double ArrayToPrint[][])

Return Values:

None / Void.
Each comma separated “row” is printed on a new line in the Experts output window.

ENJOY!

CSArrayFunctions.mq4
CSArrayFunctions.zip 

It wasn’t readily apparent to me what the heck that meant, so I did a little experimenting. I did the following:

double foo[10] = {1,2,3,4,5,6,7,8,9,10};
ArraySort(foo);
int index = ArrayBsearch(foo,4);
Print ("found: "+index);
index = ArrayBsearch(foo,11);
Print ("not found: "+index);

And got:

found: 3
not found: 9

And then did this:

double foo[10] = {1,2,3,4,5,6,7,8,9,10};
ArraySort(foo);
int index = ArrayBsearch(foo,4);
Print ("found: "+index);
index = ArrayBsearch(foo,-1);
Print ("not found: "+index);

And got:

found: 3
not found: 0

So, it seems that this means that ArrayBsearch returns either the first or the last index position if your number isn’t found in the array. To me, that’s kind of dumb, as it means you still have no idea if the first or last index position actually contains the item you are searching for! It could mean it found your value, or it could mean it DIDN’T find your value. Not really the sort of information I’m looking for in a “search” function.

If you do a Google search for “array bsearch”, you’ll find several examples of these kinds of searches. They pretty much boil down to the following:

bsearch returns a pointer to an occurrence of key in the array pointed to by base. If key is not found, the function returns NULL.

So, I created this little function as a more “sane” array search for MT4. Since we don’t have access to pointers, I just used a “-1″ return instead. I hope you like it!

ArraySearch.mq4
ArraySearch.zip